Repository navigation
ctpdev: ctpproxy publish CTP scalers - #8119
Merged
Merged
Conversation
shahor02
reviewed
Feb 12, 2022
| } | ||
| int CTPRunScalers::parseZMQScalers(std::string zmqscalers) | ||
| { | ||
| std::vector<std::string> tokens = o2::utils::Str::tokenize(zmqscalers, ' '); |
Collaborator
There was a problem hiding this comment.
this method does nothing, just creates/destroys a local vector. Is this intended?
Contributor
Author
There was a problem hiding this comment.
yes, sorry about that. It is not finished. I wanted to pull to avoid too much divergence from dev.
shahor02
approved these changes
Feb 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.