Skip to content

Support PHP 8 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Naktibalda merged 3 commits into from
Nov 7, 2020
Merged

Support PHP 8 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4940ada
Support PHP8
Naktibalda Nov 7, 2020
32f5700
Delete local copy of autogenerated documentation
Naktibalda Nov 7, 2020
fb82b42
Fixed test compatibility with PHPUnit 9
Naktibalda Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:

strategy:
matrix:
php: [5.6, 7.0, 7.1, 7.2, 7.3, 7.4]
php: [5.6, 7.0, 7.1, 7.2, 7.3, 7.4, 8.0]

steps:
- name: Checkout code
Expand All @@ -24,9 +24,7 @@ jobs:
run: composer validate

- name: Install dependencies
run: |
composer require phpunit/phpunit "<=8.5.2" --no-update --ignore-platform-reqs
composer install --prefer-dist --no-progress --no-interaction --no-suggest
run: composer install --prefer-dist --no-progress --no-interaction --no-suggest

- name: Run test suite
run: php vendor/bin/codecept run
21 changes: 0 additions & 21 deletions Robofile.php
View file
Open in desktop

This file was deleted.

5 changes: 2 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@
],
"minimum-stability": "RC",
"require": {
"php": ">=5.6.0 <8.0",
"php": ">=5.6.0 <9.0",
"ext-dom": "*",
"codeception/codeception": "^4.0",
"codeception/lib-innerbrowser": "^1.0"
},
"require-dev": {
"codeception/util-robohelpers": "dev-master",
"codeception/util-universalframework": "dev-master"
"codeception/util-universalframework": "^1.0"
},
"autoload":{
"classmap": ["src/"]
Expand Down
230 changes: 0 additions & 230 deletions documentation.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ composer require --dev "codeception/module-soap"

## Documentation

<a href="documentation.md">Look at documentation.md file</a>
[Module documentation](https://codeception.com/docs/modules/SOAP)
2 changes: 0 additions & 2 deletions src/Codeception/Module/SOAP.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
<?php
namespace Codeception\Module;

use Codeception\Lib\Interfaces\API;
use Codeception\Lib\Interfaces\DependsOnModule;
use Codeception\Lib\Notification;
use Codeception\Module as CodeceptionModule;
use Codeception\TestInterface;
use Codeception\Exception\ModuleException;
Expand Down
7 changes: 3 additions & 4 deletions tests/unit/Codeception/Module/SoapTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public function testXmlIsBuilt()
{
$dom = new \DOMDocument();
$dom->load($this->layout);
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
}

Expand All @@ -50,7 +49,7 @@ public function testBuildHeaders()
$header->appendChild($dom->createElement('username', 'davert'));
$header->appendChild($dom->createElement('password', '123456'));
$dom->documentElement->getElementsByTagName('Header')->item(0)->appendChild($header);
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
}

public function testBuildRequest()
Expand All @@ -65,7 +64,7 @@ public function testBuildRequest()
$request = $dom->createElement('ns:KillHumans');
$request->appendChild($body);
$dom->documentElement->getElementsByTagName('Body')->item(0)->appendChild($request);
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
}

public function testBuildRequestWithDomNode()
Expand All @@ -80,7 +79,7 @@ public function testBuildRequestWithDomNode()
$dom->documentElement->getElementsByTagName('Body')->item(0)->appendChild($request);

$this->module->sendSoapRequest('KillHumans', $body);
$this->assertEqualXMLStructure($this->module->xmlRequest->documentElement, $dom->documentElement);
$this->assertXmlStringEqualsXmlString($dom->saveXML(), $this->module->xmlRequest->saveXML());
}

public function testSeeXmlIncludes()
Expand Down