Skip to content

Describe the current notes layout and model split - #60

Merged
duetCJackson merged 1 commit into
mainfrom
chris/ad-137-notes-copy
Sep 23, 2026
Merged

duetCJackson merged 1 commit into
mainfrom
chris/ad-137-notes-copy

Conversation

@duetCJackson

Copy link
Copy Markdown
Collaborator

Summary

Updates the public notes copy so it matches what the app actually writes and which model each machine uses.

  • Onboarding now describes a summary, topics, and key takeaways. Decisions appear only when the meeting made them.
  • PRODUCT.md no longer says the Notes tab shows next steps.
  • The README names qwen3:4b-instruct as the default notes model, llama3.2:3b for 8 GB machines and Windows CPU low-spec machines, and qwen3-embedding:0.6b for Ask AI search.

Related: AD-137

Type of change

  • Bug fix
  • New feature
  • Documentation
  • Refactor / chore
  • Other (describe below)

Test plan

  • npm run lint
  • npm run typecheck
  • npm run test:run
  • Other (describe): npx vitest run src/renderer/src/pages/__tests__/Onboarding.test.tsx

Checklist

  • My change is focused and does not include unrelated edits.
  • I updated documentation if behavior changed.
  • I agree my contribution is licensed under the project's AGPL-3.0 license.

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 8a4cc684-e69b-4a07-ab85-0f8746715fa4

📥 Commits

Reviewing files that changed from the base of the PR and between 944cf65 and 073004e.

📒 Files selected for processing (3)
  • PRODUCT.md
  • README.md
  • src/renderer/src/pages/Onboarding.tsx

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Updated onboarding and Notes descriptions to emphasize summaries, topics, takeaways, and decisions, without referring to next steps or action items.
    • Clarified Windows hardware requirements, model selection, and fallback conditions.
    • Distinguished the models used for notes and Ask AI search.

Walkthrough

The changes update Notes descriptions and onboarding copy. The README also clarifies Windows model-selection conditions and identifies the models used for Notes, Ask AI answers, and Ask AI search.

Changes

Notes Documentation

Layer / File(s) Summary
Notes descriptions and onboarding copy
PRODUCT.md, src/renderer/src/pages/Onboarding.tsx
The Notes descriptions no longer list next steps. The onboarding copy describes summaries, grouped topics, and key takeaways.
Model selection guidance
README.md
The README adds CPU and memory conditions for using llama3.2:3b on Windows and distinguishes the Notes and Ask AI models.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 07300

The documentation and onboarding changes appear ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes to the notes layout and model assignments.
Description check ✅ Passed The description directly explains the documentation updates to notes content, model assignments, and the related test run.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@duetCJackson
duetCJackson merged commit 0cc7611 into main Sep 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant