Repository navigation
[java][bidi] Fix special-number serialization and inbound null handling - #18155
Open
SantoshSarma wants to merge 2 commits into
Open
SantoshSarma wants to merge 2 commits into
SantoshSarma wants to merge 2 commits into
Conversation
|
|
SantoshSarma
marked this pull request as ready for review
October 13, 2026 04:45
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
2 of 3 tasks
Member
|
@SantoshSarma The CLA needs to be signed, please. |
4 of 5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
Fixes #18129
💥 What does this PR do?
Fix generated Java BiDi types rejecting valid special-number wire strings, emitting raw enum objects from NumberValue.toMap(), accepting explicit null for non-nullable fields, and losing explicit-null presence for optional nullable fields.
Adds regressions for all four SpecialNumber wire values, ordinary numbers, invalid union values, SharedReference.handle:null rejection, and Info.parent null-versus-absent presence.
🔧 Implementation Notes
🤖 AI assistance
💡 Additional Considerations
Validation:
A comprehensive generator unit-test suite for #18128 remains separate from this bug fix.
🔄 Types of changes