You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Hogged transaction for less time for automation email processing - #32569
When we process automation emails' delivered/opened events, we use a database transaction. This moves a small loop out of that transaction to shorten the time we hold it.
I think this is useful on its own, but will make an upcoming change a little simpler.
towards https://linear.app/ghost/issue/NY-1704
Small performance improvement.
When we process automation emails' delivered/opened events, we use a
database transaction. This moves a small loop out of that transaction to
shorten the time we hold it.
I think this is useful on its own, but will make an upcoming change a
little simpler.
Reviewing files that changed from the base of the PR and between ef4edea and ef4edea.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
trackEmailDeliveredAndOpened now collects revision IDs associated with opened events before beginning the transaction. The transaction still locks revisions before recipients, then updates delivery and open timestamps and increments open counts.
Possibly related PRs
TryGhost/Ghost#32478: Moves action-revision locking into repository2.lockActionRevisions within trackEmailDeliveredAndOpened.
Suggested reviewers: cmraible, troyciesco
Merge Risk: Minimal · up to ef4ed
The change only shortens transaction time without moving database reads or concurrency protection, so it is mergeable.
Pre-merge checks: 7
Check name
Status
Explanation
Title check
The title clearly describes the main change: reducing the time spent in a database transaction during automation email processing.
Description check
The description accurately explains the performance improvement and the transaction change for automation email delivered/opened events.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Type-Safe Boundaries
The PR only relocates the existing revisionIds loop from inside the transaction to before it in database-automations-repository.ts. It adds no new boundary ingress, Zod bypass, any, unchecked as…
New Files Are Typescript
The pull request changes one pre-existing TypeScript file: ghost/core/server/services/automations/database-automations-repository.ts. It adds no .js, .jsx, .cjs, or .mjs source file.
Tooling Ownership
PASS. The PR changes only ghost/core/server/services/automations/database-automations-repository.ts. This is application behavior in the owning Core subsystem, not a script, tool, or shared configur…
Full details: Type-Safe Boundaries
Explanation
The PR only relocates the existing revisionIds loop from inside the transaction to before it in database-automations-repository.ts. It adds no new boundary ingress, Zod bypass, any, unchecked assertion, @ts-ignore, or duplicated schema type. The map remains an internal typed ReadonlyDeep<Map<string, AutomatedEmailEvents>> contract, and the external-event transformation already exists in the unchanged batch processor.
Full details: Tooling Ownership
Explanation
PASS. The PR changes only ghost/core/server/services/automations/database-automations-repository.ts. This is application behavior in the owning Core subsystem, not a script, tool, or shared configuration. No tooling placement or execution problem is introduced.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.
Review new or changed service boundaries for explicit dependency ownership, deterministic/idempotent initialisation, boot ordering, transaction and event semantics, cache coherence, and restart/multi-instance safety.
Review lens: "where does this data become trusted?" Boundary data (HTTP input, external API/SDK responses, env/config, DB/filesystem reads, queue/webhook/event payloads) is `unknown` until validated — Zod by default.
Applicability reference: AGENTS.md: # AGENTS.md **Ghost Core:** use the [server map](docs/codebase/monorepo-structure.md#ghost-core) and read the [services guide](ghost/core/server/services/README.md) before Source excerpt...
Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards https://linear.app/ghost/issue/NY-1704
Small performance improvement.
When we process automation emails' delivered/opened events, we use a database transaction. This moves a small loop out of that transaction to shorten the time we hold it.
I think this is useful on its own, but will make an upcoming change a little simpler.