Repository navigation
Conversation
d3xter666
marked this pull request as draft
November 5, 2026 09:08
d3xter666
added a commit
that referenced
this pull request
Nov 5, 2026
Note: this adjustment relies heavily on the implementation in #1697. Without it, the build will be failing since middlewareUtil.getResolvedFrameworkVersion() does not exists yet
d3xter666
force-pushed
the
refactor-effective-framework-version-resolution
branch
from
November 5, 2026 13:36
f12aeb1 to
9d59177
Compare
Add getResolvedFrameworkVersion to TRACKED_TASK_UTIL_METHODS and a matching resolvedFrameworkVersion branch in resolveInputValue so that a --framework-version change or workspace toggle between builds causes a cache miss and forces the task to re-run.
d3xter666
force-pushed
the
refactor-effective-framework-version-resolution
branch
from
November 5, 2026 13:44
9d59177 to
4f0bd4a
Compare
d3xter666
marked this pull request as ready for review
November 5, 2026 13:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-839
Relates to: #1681
Introduces
ProjectGraph#setResolvedFrameworkVersion/getResolvedFrameworkVersionto capture the version that actually governs the currentbuildorserverun, as opposed to the value literally written inui5.yaml.Three changes ship together:
1. Resolution logic
Workspace-first: when a workspace is active the configured version and any
--framework-versionoverride are ignored — the workspace controls what is linked. OpenUI5 reports thesap.ui.coreversion from the joined graph; SAPUI5 always stores""because no reliable distribution version is available from the workspace graph.2. Build-cache tracking
getResolvedFrameworkVersionis added toTRACKED_TASK_UTIL_METHODS. When a task reads this value the call is recorded alongside the cached output. On the next build the value is re-derived from the live graph; if it changed (--framework-versionoverride or workspace toggle), the cache misses and the task re-runs. This is prerequisite infrastructure for a follow-up PR that wires the resolved version intogenerateVersionInfoand theversionInfomiddleware (#1681).