Repository navigation
feat(unstable-v2): make ResourceLink.size unsigned and define unknown tool kinds - #2521
Merged
Merged
Conversation
… tool kinds ResourceLink.size is a byte count, so it is now u64 (minimum 0 in the schema); a negative value is discarded as unknown via DefaultOnError. Clients display an unrecognized tool kind as other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small schema fixes from the v2 spec review:
ResourceLink.sizewasi64, so negative byte counts passed validation. It is nowu64(format: uint64,minimum: 0). MCP declaressize?: numberwith no lower bound, but a byte count can't be negative, so every valid value still fits. The field usesDefaultOnError, so a negative value is treated as unknown rather than failing the message. The Rust type change is acceptable while v2 is unstable.tool-calls.mdx(main and draft) and theToolKind::Unknowndoc now say Clients display a tool kind they don't recognize asother, making the existing "generic display" fallback concrete.The fallback variant keeps its name
Unknown, becauseotheris already a known tool kind.