Skip to content

fix(unstable): null clears session_message participant IDs and message references - #2555

Merged
benbrandt merged 1 commit into
mainfrom
fix/session-message-null-clears
Oct 27, 2026
Merged

benbrandt merged 1 commit into
mainfrom
fix/session-message-null-clears

Conversation

@benbrandt

Copy link
Copy Markdown
Member

session_message treated null on senderSessionId, recipientSessionId, senderMessageId and recipientMessageId as "not supplied, keep the known value", unlike every other v2 upsert field where null clears.

These four fields now follow the standard patch convention in both v1 and v2 (unstable subagents): omitted leaves the stored value unchanged, null clears it, and a value replaces it. Malformed values are still ignored as omitted.

  • Rust: the fields are MaybeUndefined, and the builders take IntoMaybeUndefined. This is an unstable API change.
  • Updated the docs and the subagents RFD, with a revision-history entry.

@benbrandt
benbrandt requested a review from a team as a code owner October 27, 2026 20:35
@benbrandt
benbrandt enabled auto-merge (squash) October 27, 2026 20:36
@benbrandt
benbrandt merged commit b51ded3 into main Oct 27, 2026
14 checks passed
@benbrandt
benbrandt deleted the fix/session-message-null-clears branch October 27, 2026 20:39
@acp-release-bot acp-release-bot Bot mentioned this pull request Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant