Skip to content

fix(unstable-v2): require type and properties on elicitation requestedSchema - #2645

Merged
benbrandt merged 1 commit into
mainfrom
fix/v2-elicitation-schema-required
Oct 29, 2026
Merged

benbrandt merged 1 commit into
mainfrom
fix/v2-elicitation-schema-required

Conversation

@benbrandt

Copy link
Copy Markdown
Member

The docs and MCP require type: "object" and properties on a form-mode requestedSchema, but the Rust type gave both serde defaults, so the generated schema accepted {}.

  • Rust: ElicitationSchema.type_ and properties no longer have serde defaults. The generated v2 schema now lists both as required. This is a breaking change for the unstable deserializer, which now rejects a schema missing either field.
  • Test: the root-type test now checks that both fields are required and that other type values are still rejected.
  • Migration guide: added to the list of schema tightenings, since v1 didn't require them.

v2 only.

@benbrandt
benbrandt requested a review from a team as a code owner October 29, 2026 21:27
@benbrandt
benbrandt enabled auto-merge (squash) October 29, 2026 21:29
@benbrandt
benbrandt merged commit 521c328 into main Oct 29, 2026
14 checks passed
@benbrandt
benbrandt deleted the fix/v2-elicitation-schema-required branch October 29, 2026 21:32
@acp-release-bot acp-release-bot Bot mentioned this pull request Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant