Repository navigation
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: apache#69836 Problem Summary: Statement snapshot binding runs before external view SQL expansion. branch-4.2 already returns EmptyMvccSnapshot for Iceberg views, but silently ignores relation scan parameters and then reads the default view SQL. Reject every TableScanParams value before returning the existing empty view snapshot. Preserve the legacy Iceberg table path and the inherited MVCC overloads. Add tests for ordinary views and branch/tag list and map selectors, incremental reads, and options without table metadata access. ### Release note Reject unsupported branch, tag, incremental, and options scan parameters on Iceberg views instead of silently ignoring them. ### Check List (For Author) - Test: Unit Test / FE build and Checkstyle - run-fe-ut.sh --run org.apache.doris.datasource.iceberg.IcebergExternalTableTest: 25 passed, 0 failures, 0 errors, 0 skipped; reused main classes freshly compiled in this worktree. - build.sh --fe with UI disabled: the complete 27-module Maven reactor compiled and passed Checkstyle. After a verified Lance JNI download, the final FE packaging run reused the compiled classes and completed successfully with unrelated extension packaging disabled. - git diff --check passed. External catalog end-to-end regression was not run. - Behavior changed: Yes; unsupported view scan parameters now fail explicitly. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #69836