Repository navigation
Fixup gspread client init arguments - #1412
Merged
Merged
Conversation
In order to be backward compatible re-order gspread client init arguments, and assign a default value to the new argument. closes #1411 Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
Collaborator
Author
|
I will make a new release 6.0.2 right after this PR is merged in order to unblock gspread-pandas |
alifeee
approved these changes
Feb 14, 2024
alifeee
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me.
I suppose this is similar to how the Worksheet __init__ was changed with the assumption that it was not being used.
but in fact the Client object __init__ is a public function so people were using it, unexpectedly.
This is a good reminder to realise what should count as public API and try to remain compatible.
a good and quick change :)
roll on 6.0.2 :)
Collaborator
Author
|
yes exactly, that's the same problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be backward compatible re-order gspread client init
arguments, and assign a default value to the new argument.
closes #1411
Signed-off-by: Alexandre Lavigne lavigne958@gmail.com