Repository navigation
Added 'add_data_validation to Workhsheet` [Issue #1420] - #1444
Conversation
|
hi :) thanks for the PR it looks like you have to run after that, the CI should pass, and we will be able to review this change :) |
|
Hi, that looks good. Sorry there keep being issues. Try deleting the cassette, and re-running the test to generate it again. Sometimes there are conflicts. |
lavigne958
left a comment
There was a problem hiding this comment.
Hi thank you for this PR, I need to test it and check the API to confirm.
|
What type of cassette recording mode did you use ? |
lavigne958
left a comment
There was a problem hiding this comment.
thank you for this proposal. it's well made.
You do need to change the typing notation in order to pass the CI linter.
lavigne958
left a comment
There was a problem hiding this comment.
Please follow the given indications so the test + documentation build can succeed.
Could you please rename the argument showCustomUi to showCustomUI with a uppercase i, it's an acronym so it should be uppercase.
after that it's all good to, we will merge it once the changes are applied.
|
I checked and the tests won't pass until you remove the following file and record it again. Quick trick, in order to regenerate only this cassette you can use the following command: |
|
Great thanks. Last thing left is the documentation to fix then all tests should pass. |
|
Seems all tests are working, I'll flatten the commits in a moment |
bdbe891 to
e5e9291
Compare
|
this looks wonderful would we like to put it in any docs like the main :) |
|
If there is a markdown to rst converter, I'll be game.
…On Fri, Mar 29, 2024, 8:21 PM alifeee ***@***.***> wrote:
this looks wonderful
would we like to put it in any docs like the main rst example file, or
the README, so that people actually know this new function exists?
:)
—
Reply to this email directly, view it on GitHub
<#1444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2VVZQDII7B4N66JO726A3Y2V2FNAVCNFSM6AAAAABFAW7QIOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGM3TONRQGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
hmm, not sure about markdown to but I would add a simple code snippet, like ws.add_validation(
'C2:C7',
ValidationConditionType.one_of_list,
['Yes','No'],
showCustomUi=True
)to the README (1)... https://github.com/burnash/gspread/blob/master/README.md?plain=1 ...and the user guide (2)... https://github.com/burnash/gspread/blob/master/docs/user-guide.rst?plain=1 ... in an appropriate place. For (1), it's markdown. For (2), you can run |
added a generic request. finsihed the method conditon type input uses enum from utils Added a some docs and crave-out for relative dates Completed the docs. fixed the position for kwargs Adding return value Added a test for `add_validation` added validation condtion enum Added a RealtiveDate enum removed the realtive date enum fixed format errors Explicit kwargs for optional params Removed reference RelativeDate Added a type check for `condition_type`. added examples fixed formatting for docs Unbounded values to a standard iterable. Switched typing syntax to be `Optional` for compatibility. renamed range and removed blank args. re ran the test fixed the doc issue
lavigne958
left a comment
There was a problem hiding this comment.
great addon with the documentation.
please remove unwanted changes and we should be good to go
|
great work thank you for this contribution ! |
Added a RealtiveDate enum
removed the realtive date enum
Closes #1420