Repository navigation
Add test on receiving an invalid JSON in the APIError exception handler. - #1512
Merged
Merged
Conversation
Manually build an invalid JSON body. Using HTML to fake using the wrong endpoint that returns HTML instead of JSON. Use that new http client to do some request and make sure the error matches. Signed-off-by: Alexandre Lavigne <lavigne958@gmail.com>
lavigne958
force-pushed
the
test/handle_api_error_not_json
branch
from
September 22, 2024 21:25
b17a3aa to
8afb20b
Compare
Collaborator
|
looks splendid ! :) |
alifeee
approved these changes
Sep 22, 2024
Closed
Closed
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually build an invalid JSON body. Using HTML to fake using the wrong endpoint that returns HTML instead of JSON.
Use that new http client to do some request and make sure the error matches.