Repository navigation
fix(xml): keep attributes and text of the XML data root element - #759
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #758
Summary
XMLDeserializer.processDatarebuilt thexs:anydata root element withcreateElementNSand copied only its child elements. The attributes and text content of the root element were dropped, so<Order id="42">...</Order>came back as<Order>...</Order>, and<greeting>Hello World</greeting>came back empty.This change imports the whole root element with
Document.importNode(eventData, true), which keeps its namespace, attributes, and all children.Tests
v1/xml_data_with_attrs.xml(root element with attributes) andv1/xml_data_with_text.xml(root element with text only) to thedeserializeandroundTripcases inXMLFormatTest.roundTripcases fail. With the fix, all 73 tests incloudevents-xmlpass../mvnw -pl formats/xml test