Skip to content

[vendored-sync] dotnet-test-terminal-progress-renderer: drift detected (#0) #56889

Open

Description

@github-actions

Automated drift report for vendored file src/Cli/dotnet/Commands/Test/MTP/Terminal/IProgressRenderer.cs.

Source

Drift

  • Baseline blob SHA: 576ee23bcc50084a036ba79bce81b3377ad02763
  • Current blob SHA: 7361e7601a3f41f1a78832313551cba0919ea7e6
  • Baseline ref SHA : f4d8d35bf45ce0ece75a66e1b197c96684767e48
  • Current ref SHA : 07a340ead1adeb84a489ca487d7b265c8cfbf094

Links

Upstream-only diff

--- src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/IProgressRenderer.cs@576ee23
+++ src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/IProgressRenderer.cs@7361e76
@@ -17,8 +17,11 @@
 /// run goes silent or a test runs slowly (used for <see cref="AnsiMode.SimpleAnsi"/> and
 /// <see cref="AnsiMode.NoAnsi"/>, e.g. CI / piped / redirected output).</description></item>
 /// </list>
-/// All members are invoked by <see cref="TestProgressStateAwareTerminal"/> while it holds the terminal lock,
-/// except <see cref="OnTestCompleted"/> which may be called from the message pump and MUST be thread-safe.
+/// <see cref="OnWrite"/> and <see cref="OnTick"/> are invoked by <see cref="TestProgressStateAwareTerminal"/>
+/// while it holds the terminal lock. <see cref="OnStart"/> runs during initialization, before the rendering
+/// thread starts, without that lock. <see cref="TickInterval"/> is read by the rendering thread without the
+/// lock. <see cref="OnTestCompleted"/> may be called from the message pump without the lock and MUST be
+/// thread-safe.
 /// </remarks>
 [UnsupportedOSPlatform("browser")]
 [Embedded]

Local adaptation notes

Renderer strategy contract. SDK omits the optional in-process structured-progress argument, which has no IPC counterpart.

How to reconcile

  1. Review the upstream changes and decide whether they should be ported.
  2. Port the relevant changes to src/Cli/dotnet/Commands/Test/MTP/Terminal/IProgressRenderer.cs.
  3. Update eng/vendored-files.json entry dotnet-test-terminal-progress-renderer (source index 0):
    • bump baseline_ref_sha to the new upstream ref SHA,
    • bump baseline_blob_sha to the new upstream blob SHA.
  4. Close this issue once the reconciliation PR is merged.

If no port is needed (e.g. whitespace-only upstream change), still bump the baseline SHAs to silence future runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area-dotnet test (MTP)area-vendored-syncDrift detected between a vendored source file and its upstream copyuntriagedRequest triage from a team member

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions