Repository navigation
docs: add signed commits section to contributing guidelines - #2841
Merged
ashharrison90 merged 3 commits intoAug 21, 2026
Merged
Conversation
alebgl77
requested review from
academo,
andresmgot and
leventebalogh
and removed request for
a team
August 20, 2026 15:57
alebgl77
requested review from
eledobleefe and
joshhunt
and removed request for
a team
August 20, 2026 15:57
Contributor
There was a problem hiding this comment.
Pull request overview
Adds signed-commit requirements and guidance to CONTRIBUTING.md.
Changes:
- Documents signing requirements and verification links.
- Adds instructions for signing existing commits.
- Adds the section to the table of contents.
Suppressed comments (1)
CONTRIBUTING.md:135
- This adds a second complete copy of the
Signed Commitssection immediately after the one above, so the rendered guide repeats the entire policy and rebase instructions. Please remove this duplicate block and keep only one section.
## Signed Commits
Effective June 22, 2026, all Grafana Labs repositories [require signed commits](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-signed-commits). Commits that GitHub cannot verify will block your pull request from being merged.
> **Note**
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sunker
reviewed
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2823
Adds a
Signed Commitssection toCONTRIBUTING.md, modelled on the Grafana contributing guide as suggested in the issue.Right now
CONTRIBUTING.mddocuments the CLA and the conventional-commit title rules, but says nothing about commit signing. Contributors discover the requirement from the automated info box on their pull request, after they have already pushed.The new section covers:
It sits directly after the CLA section, since both are gates a pull request has to clear before it can be merged, and it is listed in the table of contents.
The commit on this pull request is signed.