Repository navigation
Conversation
JoeCqupt
force-pushed
the
feat/csds-handle-request-completion-test
branch
from
November 4, 2026 08:01
3d31555 to
4534fe6
Compare
Contributor
Author
|
@kannanjgithub @sergiitk PTAL |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a test for the CSDS unary RPC that verifies an invalid request calls
responseObserver.onError()withINVALID_ARGUMENTand never callsresponseObserver.onCompleted().This covers the case described by the TODO: if
handleRequest()were toreturn
trueafter reporting an error, the test would fail. The internalservice class is package visible so the test can verify the observer directly.