Repository navigation
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
frenck
left a comment
There was a problem hiding this comment.
Hi @Ironoxx, thanks for the submission! 👋
custom_components/snapmaker_u1_card/resource.py(lines 30-45 and 84-99) copies the card into/config/www/snapmaker_u1_card/on every setup and registers a/local/snapmaker_u1_card/...dashboard resource for it. Integrations should not put their files into the user'swwwfolder: it is user space, served unauthenticated, and the copy lingers outside what HACS manages. You already serve the card from its own static path (CARD_URLviaasync_register_static_pathsin__init__.py), so please point the dashboard resource at that URL instead, and drop the copy (and thermtreecleanup that goes with it).custom_components/snapmaker_u1_card/blueprints.py(lines 23-30) andvoice.py(lines 197-209) overwrite the installed blueprint and the Assist sentence files on every start whenever the content differs and the managed comment line is still there. A user who edits the blueprint or the sentences without knowing about that comment loses their changes on the next restart. Please only write these files when they are missing, or when the existing file is byte-identical to a version you shipped earlier (for example, compare against a hash of each previous release), and leave anything else alone.
Once that's addressed, push a new release and re-request review.
../Frenck
Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter
|
Thanks a lot for the review, @frenck!! Both points make sense, I'm on it and will push a new release and re-request review once it's done. |
Checklist
Links
Link to current release: https://github.com/Ironoxx/ha-snapmaker-u1-card/releases/tag/v2.1.0
Link to successful HACS action (without the
ignorekey): https://github.com/Ironoxx/ha-snapmaker-u1-card/actions/runs/41978550974Link to successful hassfest action (if integration): https://github.com/Ironoxx/ha-snapmaker-u1-card/actions/runs/41978550974
Description
All-in-one integration and dashboard card for the Snapmaker U1 (4-head tool changer, Klipper/Moonraker). It talks to the printer directly, so the Moonraker integration is not needed: live values and controls, print start with filament mapping, layer view with G-code preview, camera (WebRTC/RTSP/MJPEG), Spoolman with per-head usage, notifications, power switch with clean shutdown, energy and cost per print, maintenance and self test. Works with the stock firmware and the paxx12 Extended Firmware. Domain
snapmaker_u1_card, brand images included in the integration.