[patrickk88]

Checklist

• I've read the publishing documentation.
• I've added the HACS action to my repository.
• (For integrations only) I've added the hassfest action to my repository.
• The actions are passing without any disabled checks in my repository.
• I've added a link to the action run on my repository below in the links section.
• I've created a new release of the repository after the validation actions were run successfully.

Links

Link to current release: https://github.com/patrickk88/aquamedic-local/releases/tag/v0.1.0
Link to successful HACS action (without the ignore key): https://github.com/patrickk88/aquamedic-local/actions/runs/41996942357
Link to successful hassfest action (if integration): https://github.com/patrickk88/aquamedic-local/actions/runs/41996942357

🤖 Generated with Claude Code

https://claude.ai/code/session_01XwA7uP3kHSPCxwEc9uuuET

[hacs-bot]

Thank you for submitting your repository to HACS (Home Assistant Community Store).

Your submission is in the review queue:
Your repository is waiting to be reviewed and included in HACS.

You can view the current queue here. Pull requests are processed in the order they were created, oldest first.

What to avoid during review:
To help reviewers work efficiently, don't do the following:

• Comment on the pull request - The reviewer will contact you when they have feedback or questions.
• Open a new pull request - This won't speed up the process and creates duplicate work.
• Ask followers to comment on the pull request - This won't speed up the process and may delay your review.
• Merge in the default branch - Only do this if a maintainer asks you to resolve a merge conflict.

If you need to make changes:
You can continue updating your repository while waiting for review. Changes to your repository will be reflected when the reviewer examines it. Only comment on the pull request if you need to withdraw your submission or have critical information for reviewers.

About draft pull requests:
Draft pull requests aren't included in the review queue. Your pull request may be marked as draft by a reviewer if issues need to be addressed. Once you've resolved all issues, mark it as ready for review to re-enter the queue.

What happens next:
Once a reviewer examines your submission, they'll either:

• Approve and merge your pull request if everything meets the requirements
• Request changes or ask questions if adjustments are needed

[frenck]

Hi @patrickk88, thanks for the submission! 👋

One thing needs fixing before this can go in.

1. The README says the DC Runner controls are untested ("untested - decoded from the public datapoint schema") and that on the EcoDrift writing is only tested with flow and frequency. The integration still writes everything else to the pump: on the DC Runner on/off, speed, feed pause and timer (custom_components/aquamedic_local/protocol.py, _DC_WRITE, lines 507 to 512), and on the EcoDrift pump on/off, wave mode, wave form, feed pause, timer and linkage (_ECODRIFT_WRITE, lines 496 to 506). These pumps keep a tank alive, and a write that has never been seen to work on a real pump can stop the flow or change how a pump couples to the others (linkage master or slave). Payloads that are not confirmed on hardware should not be sent to a device. Please either confirm each of these writes on a real pump and say so in the README, or remove the ones you have not verified until someone has. For the DC Runner that means shipping it read only: leave out its switch, number and feed controls.

Also not blocking: once the repository is in the default list, lead the README install section with searching for it in HACS.

Once that's addressed, push a new release and re-request review.

../Frenck

                       

Blogging my personal ramblings at frenck.dev
Or subscribe to my free bi-weekly newsletter: frenck.dev/newsletter