Repository navigation
fix(uri): reject unconsumed trailing bytes in Authority::from_static - #882
Open
duongynhi000005-oss wants to merge 1 commit into
Open
duongynhi000005-oss wants to merge 1 commit into
duongynhi000005-oss wants to merge 1 commit into
Conversation
`validate_authority_bytes` stops at the first `/`, `?`, or `#` delimiter and returns the end index of the authority segment. While `create_authority` checks `authority_end != s.len()`, `Authority::from_static` matched `Ok(_)` and discarded the returned offset, allowing strings with a scheme prefix or trailing path/query/fragment (such as `"https://127.0.0.1"`) to construct an invalid `Authority`. Require `Ok(end) if end == src.len()` in `Authority::from_static` so its validation matches `Authority::from_str`. Fixes hyperium#879 Signed-off-by: duongynhi000005-oss <duongynhi000005@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #879
Summary
validate_authority_bytesstops scanning at the first/,?, or#delimiter and returns the byte index where the authority segment ended.create_authority(used byFromStr/TryFrom) checksauthority_end != s.len(), whereasAuthority::from_staticmatchedOk(_)and ignored the returned end index—accepting inputs like"https://127.0.0.1"or"example.com/path"thatparse::<Authority>()rejects.Changes
Authority::from_staticwithOk(end) if end == src.len().# Panicsrustdoc onAuthority::from_static.