Repository navigation
fix(uri): parse uppercase http/https as standard schemes - #883
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
Scheme::from_str("HTTP") produced Scheme2::Other, which is not equal to
Scheme::HTTP and hashes differently, while parsing a full Uri lowercases
the scheme and gets Scheme::HTTP. Match the two standard schemes
case-insensitively so both paths agree.
patrick-immometrica
marked this pull request as ready for review
November 5, 2026 11:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheme::from_str("HTTP")returns anOtherscheme instead of the standard one. The case-insensitive compare from #485 only applies between twoOtherschemes, so the parsed value is never equal toScheme::HTTP. It also hashes differently, andas_str()returns"HTTP". Parsing a fullUrialready lowercases the scheme, so only the standalone parse is affected:parse_exactnow matcheshttp/httpswitheq_ignore_ascii_case. RFC 3986 3.1 says schemes are case-insensitive, and this is the scheme part of #46.The new test fails on master with
and passes with the change.