Repository navigation
Add HTTP1 server config for allowing multiple spaces in parsing #3923
Description
Is your feature request related to a problem? Please describe.
We have a situation that we want to allow request to have multi spaces as a request line delimiter.
However, I found that the parser config for server is not exposed to the server builder unlike client.
Because of this, there is no way to use Hyper server to support those use case even though httparse crate has a flag for that feature.
Describe the solution you'd like
Expose the parser config in the similar way as Hyper Client.
As it will be configurable in the builder, it will not break other existing server behavior.
Client side example code: https://code.amazon.com/packages/S3DataEngineHyper/blobs/62a7a6badaba2858361fdc633727a97aed4c8853/--/src/client/conn/http1.rs#L350
Describe alternatives you've considered
- Update the httparse crate default configuration, but this will break the backward compatibility
- Expose ParserConfig itself to the Builder. However, this will make Hyper user to have coupling with httparse config
Additional context
Add any other context or screenshots about the feature request here.
Activity
seanmonstar commentedon Aug 1, 2025
Assuming you mean add configuration methods to the server
http1::Builderfor those options, definitely![-]Expose parser config as a Server configuration like Client[/-][+]Add HTTP1 server config for allowing multiple spaces in parsing[/+]magurotuna commentedon Dec 7, 2025
This was resolved by #3929 so I presume we can close it?
heiwais25 commentedon Dec 8, 2025
Sorry for late. I double checked and found the ask was to expose this feature for the server.
hyper/src/proto/h1/role.rs
Line 165 in 1c70fab
The change was about enhancing
h1_parser_config, and found it is not actually used by Server implementation. It is used by Client only.Please correct me if I'm wrong.
heiwais25 commentedon Dec 8, 2025
I believe we need to reopen the ticket again unless I missed the implementation for Server.
We can do like using
match ctx.h1_parser_config.parse_request~~()with the default config used currentlyI was occupied with others, but now I have some time. Let me create a PR for this.
seanmonstar commentedon Dec 8, 2025
Ah, I see. So the builder method was added to the public API, but the parser doesn't yet use that config.
heiwais25 commentedon Dec 8, 2025
Yes, that's correct.
0xPoe commentedon Jan 3, 2026
@heiwais25 I have created a PR for it: #4002. I hope I understood your request correctly, and I also added unit tests. It seems to work well.
fix(http1): use httparse config for Servers (#4002)
heiwais25 commentedon Jan 5, 2026
Thanks! @0xPoe
fix(http1): use httparse config for Servers (hyperium#4002)
fix(http1): use httparse config for Servers (hyperium#4002)