Repository navigation
Return Mail search pages when the scope count times out - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Mail search also counts the indexed messages in the selected mailbox, or in the whole store when no mailbox is selected, without the search filters (mattt/iMCP#312). The count runs after the page, in the same read transaction. On a large Mail store, it can pass the default 100 ms statement limit, and the search throws
queryTimedOutand discards the page.This PR makes the count best effort. When counting passes the statement or snapshot time limit,
searchreturns the page and its next cursor with anilindexedMessageCount. Other errors and cancellation still propagate. The count also leaves out the joins tosubjectsandaddresses, which can't change it.SearchResult.indexedMessageCountis nowInt?, which is a source-breaking change.