Repository navigation
fixing some consistency issues with repo search vs featured cards - #11733
Open
Joey Wunderlich (jwunderl) wants to merge 1 commit into
Open
Joey Wunderlich (jwunderl) wants to merge 1 commit into
Joey Wunderlich (jwunderl) wants to merge 1 commit into
Conversation
Joey Wunderlich (jwunderl)
requested review from
a team
and
a max review from Copilot
November 2, 2026 19:20
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Package-name-based matching can misidentify unrelated GitHub search results as installed, opening update/remove actions for the wrong dependency.
4 open issues
What changed in this PR
This PR unifies GitHub extension card metadata in the PXT editor so featured, searched, and installed extensions use consistent names, descriptions, and images.
Changes:
- Centralizes card metadata normalization and icon resolution.
- Carries package metadata through GitHub responses and refreshes installed-card metadata.
- Adds tests for metadata precedence, icon handling, and search/direct-lookup consistency.
| File | Description |
|---|---|
webapp/src/extensionsBrowser.tsx |
Uses shared metadata handling and refreshes installed extension cards. |
webapp/src/extensionMetadata.ts |
Adds shared card metadata normalization and fallback logic. |
tests/pxt-editor-test/editorrunner.ts |
Tests card consistency, metadata fallbacks, and icon behavior. |
pxtlib/github.ts |
Exposes package metadata and resolves explicit versus repository-relative icons. |
Review effort: Max
| fileName: options?.fileName?.toLocaleLowerCase(), | ||
| name: r.name, | ||
| description: r.description, | ||
| name: r.packageMetadata?.name || r.name, |
| name: r.packageMetadata?.name || r.name, | ||
| displayName: r.packageMetadata?.displayName, | ||
| icon: r.packageMetadata?.icon, | ||
| description: r.packageMetadata?.description || r.description || "", |
| slug: rid.slug, | ||
| name: rid.fileName ? `${meta.name}-${rid.fileName}` : meta.name, | ||
| displayName: meta.displayName, | ||
| icon: meta.icon, |
| displayName: config.displayName, | ||
| type: ExtensionType.Github, | ||
| imageUrl: config.icon || pxt.github.repoIconUrl(repo), | ||
| pkgConfig: config, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frontend side of proper fix for https://github.com/microsoft/pxt-minecraft/issues/3131 and the related issues, to make it so extensions show up the same when installed, searched, and featured. Don't wanna stick this into minecraft release since needs more testing + fix for the bug we actually saw is just removing a line from pxt.json