Skip to content

Feature: Select screen to show Leader Key on - #200

Merged
mikker merged 1 commit into
mikker:mainfrom
LennartEgb:screen-chooser
May 6, 2025
Merged

mikker merged 1 commit into
mikker:mainfrom
LennartEgb:screen-chooser

Conversation

@LennartEgb

@LennartEgb LennartEgb commented May 5, 2025 •

Copy link
Copy Markdown
Contributor

This fixes #30 and #185.

In this PR the option for the screen to "Show Leader Key on" is added.
Followed the selection in Raycast.

Advanced pane Selection
advanced-pane selection

In addition a bug is fixed where the Cheater theme is misplaced on one screen if multiple screens are used.

No UI changes, only positioning. The positioning of Mystery Box and For The Horde theme might need to be adjusted. The previous positioning of these themes were calling NSWindow.center method only in the show function.

Add screen setting to AdvancedPane

Pass screen to render the theme on

Set frame origin in Cheater theme

update placements of ForTheHorde, MysteryBox and Mini theme

Make screen parameter required and add center helper function on
NSScreen

Fix center and positioning

@zenangst zenangst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@mikker

mikker commented May 6, 2025

Copy link
Copy Markdown
Owner

Glorious work, Lennart! ❤️🧡💛💚💙💜

@mikker
mikker merged commit b2c1016 into mikker:main May 6, 2025
@mikker

mikker commented May 6, 2025

Copy link
Copy Markdown
Owner

And thank you for reviewing @zenangst 🫡

@LennartEgb
LennartEgb deleted the screen-chooser branch May 7, 2025 07:31
unstrike pushed a commit to unstrike/Relay that referenced this pull request Mar 28, 2026
Add screen setting to AdvancedPane

Pass screen to render the theme on

Set frame origin in Cheater theme

update placements of ForTheHorde, MysteryBox and Mini theme

Make screen parameter required and add center helper function on
NSScreen

Fix center and positioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Choose Screen for Popup

3 participants