Repository navigation
Fix missing error check in ContainerTop on Windows - #52025
Merged
Merged
Conversation
Signed-off-by: Jack Phillips <jack.phillips@datadoghq.com>
jack0x2
force-pushed
the
fix-top-windows-nil-task-panic
branch
from
February 10, 2026 17:36
e78e538 to
146c702
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a missing error check in
ContainerTopon Windows that could cause a nil pointer panic.- How I did it
Added an
if err != nilcheck after the IIFE that acquires the running task under lock indaemon/top_windows.go. Previously, ifGetRunningTask()failed (e.g., container not running) or the container was in a restarting state, the error was silently dropped andtask.Summary()was called on a nil task, resulting in a panic.- How to verify it
docker topagainst a stopped or restarting Windows container.This matches the existing error handling pattern in
daemon/top_unix.go.- Human readable description for the release notes