[rzlink]

Summary

docker stats reported all zeros for running Windows containers under the
containerd runtime (io.containerd.runhcs.v1). The runhcs shim emits metrics
with the typeurl containerd.runhcs.stats.v1.Statistics, which the daemon
never registered, so typeurl.UnmarshalAny failed and an empty record was
returned. This is the failure reported in
#52913 (comment), and addresses
the "stats may be broken on Windows" blocker in #51643.

Changes

• Import the hcsshim runhcs stats package so its proto init() registers the
  typeurl (go mod vendor pulls it from the vendored hcsshim v0.14.1).
• Handle *wstats.Statistics in InterfaceToStats, converting it to the
  existing *hcsshim.Statistics shape (with ns→100ns scaling) so
  stats_windows.go is unchanged.
• Un-skip TestStatsAllNoStream / TestStatsAllRunningNoStream and add a unit
  test for the conversion.

Testing

• Unit test covers the conversion, ns→100ns scaling, and the nil payload.
• Verified manually: docker stats now reports non-zero CPU/memory/block I/O
  on a containerd-runtime daemon.
• Both un-skipped tests pass on Windows CI (graphdriver+containerd and
  snapshotter+containerd).

Release notes (optional)

Fix `docker stats` reporting all zeros for running Windows containers when using the containerd runtime.

[rzlink]

@vvoland would you be able to review this? Thanks!

[vvoland]

Thanks!

Could you also unskip the integration tests?

moby/integration/container/stats_test.go

Line 105 in 11ee7e0

skip.If(t, testEnv.RuntimeIsWindowsContainerd(), "FIXME: Broken on Windows + containerd combination")

[vvoland]

Also, please rebase on top of latest master to fix the red CI

[rzlink]

Thanks!

Could you also unskip the integration tests?

moby/integration/container/stats_test.go

Line 105 in 11ee7e0

skip.If(t, testEnv.RuntimeIsWindowsContainerd(), "FIXME: Broken on Windows + containerd combination")

On un-skipping  TestStatsNetworkStats : this PR fixes CPU/memory/storage but not network stats, which that test asserts. The runhcs shim's metrics ( WindowsContainerStatistics ) carry no network data, so  Networks  comes back empty on the containerd path.  

Sourcing network stats for the containerd path looks like a separate, non-trivial piece of work, so I'd prefer to keep it as a follow-up and keep this PR focused. The CPU/memory tests ( TestStatsAllNoStream ,  TestStatsAllRunningNoStream ) are un-skipped here and pass. Would you be OK with that split?

[rzlink]

Also, please rebase on top of latest master to fix the red CI

Thanks for the review! I've rebased on latest master to fix the red CI.

[rzlink]

Also, please rebase on top of latest master to fix the red CI

One thing I can't do myself: the only remaining red check is  check-changelog , which wants an  impact/  label whenever there's a changelog note. Could you add the appropriate  impact/  label (or let me know if you'd rather I drop the release note)?

[vvoland]

Added the label, changelog entry is definitely good to have!

For TestStatsNetworkStats - haven't looked into it yet, but could we split it so that we run the part we already support and skip the network stats for now?

[rzlink]

Added the label, changelog entry is definitely good to have!

For TestStatsNetworkStats - haven't looked into it yet, but could we split it so that we run the part we already support and skip the network stats for now?

TestStatsNetworkStats is stays skipped (it's wholly a network-stats test — ping + packet-count assertion — so there's no CPU/mem part to separate out).

I went ahead and implemented the network-stats piece too and validated it end-to-end — I'll open it as a follow-up PR once this one lands.

[vvoland]

LGTM, thanks!