Repository navigation
fix: ship dark + light logo SVGs missed in #1 (GTM-64) - #2
Merged
Merged
Conversation
GitHub renders the org README on both light and dark themes depending on the visitor's setting. The previous wsrv.nl-rendered PNG of the primary (teal) logo worked on light but the small black "m" inside the teal mark got lost on dark, and the teal wordmark dropped to low contrast. Added two SVG variants in `profile/`: - `logo-light.svg` — original teal mark + black inner-m + teal MODEM wordmark. Unchanged from the brand kit's LogoFullMPrimary.svg. - `logo-dark.svg` — same artwork with the teal swapped to cream (#FCFAF5, on-brand from the kit) and the black inner-m swapped to cream too. Pure cream-on-transparent for high contrast on GitHub's near-black dark theme. README now uses <picture> with prefers-color-scheme media queries — the standard GitHub pattern. Falls back to logo-light.svg for clients that don't support <picture> (none on modern GitHub, but covered). SVGs are referenced via raw.githubusercontent.com pinned to HEAD so the README on github.com/modem-dev always renders the latest committed assets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #1 merged with the README using
<picture>+prefers-color-scheme, but the second commit on that branch (the one addinglogo-dark.svg+logo-light.svg) never made it into the merge. Result: every<img>on the live org page at github.com/modem-dev is currently broken (404s on the raw SVG URLs).This PR ships the two missing files and pins the README's raw URLs to
maininstead ofHEADfor cache stability.Changes
profile/logo-light.svg— original teal-on-anything brand-kit logo (unchanged fromLogoFullMPrimary.svg)profile/logo-dark.svg— same artwork, teal + black swapped to cream (#FCFAF5) for high contrast on GitHub's dark themeprofile/README.md— raw URLs pinned to/main/so the logo doesn't break if HEAD is ever ambiguousVerify
After merge, open https://github.com/modem-dev in both light + dark theme. Logo should swap automatically.
🤖 Generated with Claude Code