Skip to content

feat(cli): link GitHub release notes after hunk update - #1166

Merged
benvinegar merged 2 commits into
mainfrom
fix/update-github-release-notes
Oct 12, 2026
Merged

benvinegar merged 2 commits into
mainfrom
fix/update-github-release-notes

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • Incorporates the implementation from feat(cli): link release notes after hunk update #1022, preserving contributor attribution, and switches release-notes links to GitHub releases so they do not depend on hunk.dev deployment.
  • Prints a plain URL after a successful update, when already current, and for --check.
  • Keeps --check links aligned with the channel’s latest release, even when an explicit version is supplied.
  • Removes website-specific URL derivation and generated-page tests in favor of GitHub tag URL coverage.

Closes #951. Intended as an alternative to #1022; do not merge both.

Verification

  • bun test packages/hunk/src/core/run/releaseNotes.test.ts packages/hunk/src/core/install/selfUpdate.test.ts: 39 passed.
  • bun run typecheck, bun run lint, bun run deps:check: passed.
  • Original feat(cli): link release notes after hunk update #1022 merged into fresh main: bun run test passed (4,819 tests, 13 skipped); the full suite was not rerun after changing the URL destination.
  • Tested on Linux; Windows and macOS not tested locally.

Example

Updated hunk to 0.21.0.
Release notes: https://github.com/modem-dev/hunk/releases/tag/v0.21.0

Limitations

URLs are constructed without a network existence check; the corresponding GitHub release must still be published.

This PR description was generated by Pi using gpt-6.1-sol

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low impact] CLI adds GitHub release links to update output.

The release-note behavior looks sound, but the explicit style requirement must be satisfied before merging.

Findings

  1. P2 New files break style rules ▶
Fix with agent prompt
### Issue 1
packages/hunk/src/core/run/releaseNotes.ts:8-10
The new `releaseNotes.ts` and `releaseNotes.test.ts` files use camelCase filenames and two-space indentation. The repository style guide requires dash-case filenames and four-space indentation. Rename both files, update their imports, and adjust the indentation. This explicit requirement must be satisfied before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds plain GitHub release-note URLs to hunk update.

  • Hunk update prints a link to the matching GitHub release.

Acknowledgment: benvinegar’s supplied PR description states that URL existence checks are intentionally omitted and that the matching GitHub release must be published.

Reviews (1) · Last reviewed commit: "fix(cli): link update notes to GitHub re..." · Reviewed by Greptile

Comment on lines +8 to +10
if (!isComparableVersion(version)) {
return undefined;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 New files break style rules

The new releaseNotes.ts and releaseNotes.test.ts files use camelCase filenames and two-space indentation. The repository style guide requires dash-case filenames and four-space indentation. Rename both files, update their imports, and adjust the indentation. This explicit requirement must be satisfied before merging.

Context Used: guidelines.mdc Cursor rule (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/hunk/src/core/run/releaseNotes.ts
Line: 8-10

Comment:
**New files break style rules**

The new `releaseNotes.ts` and `releaseNotes.test.ts` files use camelCase filenames and two-space indentation. The repository style guide requires dash-case filenames and four-space indentation. Rename both files, update their imports, and adjust the indentation. This explicit requirement must be satisfied before merging.

**Context Used:** guidelines.mdc Cursor rule ([source](https://github.com/modem-dev/modem/blob/main/.cursor/rules/guidelines.mdc))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@benvinegar
benvinegar enabled auto-merge (squash) October 12, 2026 17:51
@benvinegar
benvinegar merged commit 7572a22 into main Oct 12, 2026
14 checks passed
@vercel

vercel Bot commented Oct 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
hunk-web Ignored Ignored Oct 12, 2026 6:39pm UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show release notes after hunk update

2 participants