Repository navigation
feat(cli): link GitHub release notes after hunk update - #1166
Conversation
|
| if (!isComparableVersion(version)) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
The new releaseNotes.ts and releaseNotes.test.ts files use camelCase filenames and two-space indentation. The repository style guide requires dash-case filenames and four-space indentation. Rename both files, update their imports, and adjust the indentation. This explicit requirement must be satisfied before merging.
Context Used: guidelines.mdc Cursor rule (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/hunk/src/core/run/releaseNotes.ts
Line: 8-10
Comment:
**New files break style rules**
The new `releaseNotes.ts` and `releaseNotes.test.ts` files use camelCase filenames and two-space indentation. The repository style guide requires dash-case filenames and four-space indentation. Rename both files, update their imports, and adjust the indentation. This explicit requirement must be satisfied before merging.
**Context Used:** guidelines.mdc Cursor rule ([source](https://github.com/modem-dev/modem/blob/main/.cursor/rules/guidelines.mdc))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Summary
--check.--checklinks aligned with the channel’s latest release, even when an explicit version is supplied.Closes #951. Intended as an alternative to #1022; do not merge both.
Verification
bun test packages/hunk/src/core/run/releaseNotes.test.ts packages/hunk/src/core/install/selfUpdate.test.ts: 39 passed.bun run typecheck,bun run lint,bun run deps:check: passed.bun run testpassed (4,819 tests, 13 skipped); the full suite was not rerun after changing the URL destination.Example
Limitations
URLs are constructed without a network existence check; the corresponding GitHub release must still be published.
This PR description was generated by Pi using gpt-6.1-sol