Repository navigation
[Frontend] Service edit page - #60
Open
pallasathena92 wants to merge 3 commits into
Open
pallasathena92 wants to merge 3 commits into
pallasathena92 wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Plan Phase 2, last frontend item:
app/(dashboard)/services/[name]/edit/page.tsx, the page the detail page's Edit button and the list's edit action link to. It loads the service by name and?namespace=, and renders theServiceFormfrom #58 in edit mode with the YAML tab open first, since the form owns only the common fields and the YAML shows the whole stored object. Saving goes through the form's pipeline (schema check, API server dry run, real update keepingresourceVersion) and returns to the detail page. A missing service shows the error with a way back.ServiceFormgains adefaultTabprop for this.Based on #59 with #58 merged in (it needs both the detail page and the form), so the diff shows #58's commits until that merges; the new work is the last commit.
Why we need it
Editing a service meant
kubectl edit; the console linked to an edit page that did not exist.How to test
cd frontend && npm run typecheck && npm run lint && npm run format:check && npm run gen:types:check && npm testpass (140 tests; new: the page loads by name and namespace, opens on the YAML tab, returns to the detail page after saving, and shows the not-found error with a back link).spec.engine.minReplicasin the YAML, save, and see the detail page refresh with the new value.Checklist
make testpasses locally — frontend; backend untouched