Repository navigation
fix(release): verify direct publishing and document pnpm trust errors - #352
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Latest result Pull request merged. Final answersSession Pull request merged. Session Waiting for GitHub merge request 8ae06a88-23b8-4c8e-93ed-2d04f58be576. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. Session Pushed 5a4dba3 fixing Pullfrog’s P1 staged-approval acceptance and P2 hidden publisher metadata; resolved both threads. Registry regression cases using jq, documented npm view, bash -n, vp fmt --check, and git diff --check passed. Docs lint was blocked locally by unbuilt comark-linter/dist/doctor.mjs. Awaiting CI and automated review. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Important
The new release check does not yet verify the direct-publishing transition, and the documented inspection command hides one of the fields readers are told to review.
Reviewed changes in commit 470a768, covering the release verification gate and the new pnpm trust guidance.
- Release verification — Requires each published version to expose GitHub trusted-publisher metadata and SLSA v1 provenance before the release succeeds.
- Consumer guidance — Documents
ERR_PNPM_TRUST_DOWNGRADE, exact-version exclusions, metadata review, and a local CLI smoke test. - Agent guidance — Directs agents to the policy documentation and requires user authorization before adding an exception.
gpt-5.6-sol | 𝕏
comark-annotate
comark-badge
comark-cards
comark-carousel
comark-cast
comark-charts
comark-chat
comark-chips
comark-cjk
comark-code
comark-code-notes
comark-colors
comark-comments
comark-critic
comark-deflist
comark-details
comark-diagrams
comark-diff
comark-embed
comark-fields
comark-figure
comark-file-tree
comark-footnotes
comark-github
comark-icon
comark-include
comark-keys
comark-links
comark-linter
comark-magic-move
comark-mark
markdown-it-to-comark
marked-to-comark
comark-mathml
comark-media
comark-metrics
migrate-to-comark
comark-outline
comark-properties
comark-qr
comark-quiz
comark-reading-time
remark-to-comark
comark-sources
comark-steps
comark-table
comark-tabs
comark-tests
comark-time
comark-ui
comark-xref
comark-zoom
commit: |
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes since the prior Pullfrog review, focusing on the direct-publishing verification fix and corrected inspection guidance.
- Rejected staged approvals — Added an
_npmUser.approverabsence check so staged-and-approved releases no longer satisfy the direct GitHub publishing gate. - Clarified verification failures — Updated workflow errors and summaries to identify direct trusted publishing as the required state.
- Exposed trusted-publisher metadata — Requested
_npmUser.trustedPublisher.idexplicitly in the documentednpm viewcommand.
Validated the workflow predicate against live npm manifests: staged comark-annotate@0.2.0 is rejected and direct comark-annotate@0.9.1 is accepted. The documented command also displays the expected github publisher ID.
gpt-5.6-sol | 𝕏

pnpm's
no-downgradepolicy rejectscomark-annotate@0.9.1because older releases used staged publishing with npm approval. Direct GitHub OIDC publishing still has provenance, but pnpm ranks the older approval step higher.This keeps releases automatic from GitHub, with no npm approval. Release verification now checks GitHub trusted-publisher and provenance metadata. The installation docs explain the history and show exact-version exceptions for annotate, carousel, and zoom. The agent skill links to that guidance when this error occurs. Consumers still need to accept the publishing change in their own pnpm policy.
pnpm readyand docs generation pass. A real0.9.1install fails for those three packages without exceptions, succeeds with the documented exceptions, and runs the annotation CLI successfully.