Skip to content
This repository was archived by the owner on Jul 14, 2026. It is now read-only.

fix(web-app-files): [OCISDEV-915] add explicit size to space image - #13835

Merged
LukasHirt merged 1 commit into
masterfrom
fix/space-img-size
Jun 2, 2026
Merged

LukasHirt merged 1 commit into
masterfrom
fix/space-img-size

Conversation

@LukasHirt

Copy link
Copy Markdown
Collaborator

Description

The space header image did not have explicit width and height causing the image to overflow its container. Adding explicit width and height with values of 100% makes sure that the image stays within the boundaries of the container.

Related Issue

Motivation and Context

Image is not overlapping the content.

How Has This Been Tested?

  • test environment: macos, chrome
  • test case 1: upload a vertical image

Screenshots (if appropriate):

image

@LukasHirt LukasHirt self-assigned this Jun 2, 2026
@kw-security

kw-security commented Jun 2, 2026 •

Copy link
Copy Markdown
Contributor

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

The space header image did not have explicit width and height causing
the image to overflow its container. Adding explicit width and height
with values of 100% makes sure that the image stays within the
boundaries of the container.

Signed-off-by: Lukas Hirt <info@hirt.cz>
@LukasHirt
LukasHirt force-pushed the fix/space-img-size branch from c073da6 to 51406cc Compare June 2, 2026 09:17
@sonarqubecloud

sonarqubecloud Bot commented Jun 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
40.3% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarQube Cloud

@LukasHirt
LukasHirt merged commit f769bdf into master Jun 2, 2026
20 of 21 checks passed
@LukasHirt
LukasHirt deleted the fix/space-img-size branch June 2, 2026 18:33
LukasHirt added a commit that referenced this pull request Jun 3, 2026
…13835)

The space header image did not have explicit width and height causing
the image to overflow its container. Adding explicit width and height
with values of 100% makes sure that the image stays within the
boundaries of the container.

Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt added a commit that referenced this pull request Jun 5, 2026
…13835)

The space header image did not have explicit width and height causing
the image to overflow its container. Adding explicit width and height
with values of 100% makes sure that the image stays within the
boundaries of the container.

Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt added a commit that referenced this pull request Jun 8, 2026
…13835)

The space header image did not have explicit width and height causing
the image to overflow its container. Adding explicit width and height
with values of 100% makes sure that the image stays within the
boundaries of the container.

Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt added a commit that referenced this pull request Jun 9, 2026
…13835)

The space header image did not have explicit width and height causing
the image to overflow its container. Adding explicit width and height
with values of 100% makes sure that the image stays within the
boundaries of the container.

Signed-off-by: Lukas Hirt <info@hirt.cz>
LukasHirt added a commit that referenced this pull request Jun 9, 2026
…13835) (#13838)

The space header image did not have explicit width and height causing
the image to overflow its container. Adding explicit width and height
with values of 100% makes sure that the image stays within the
boundaries of the container.

Signed-off-by: Lukas Hirt <info@hirt.cz>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OCISDEV-915] File list overlaps preview image for certain image dimensions/resolutions

3 participants