Repository navigation
Add RFC for testing CRCR L4 behavior against production PyTorch - #112
Open
can-gaa-hou wants to merge 2 commits into
Open
can-gaa-hou wants to merge 2 commits into
can-gaa-hou wants to merge 2 commits into
Conversation
albanD
reviewed
Sep 30, 2026
| This RFC proposes how to do that with the existing canary repo [`pytorch/crcr-test`](https://github.com/pytorch/crcr-test): | ||
|
|
||
| 1. Promote `pytorch/crcr-test` from allowlist level **L3 → L4** in the production CRCR relay. | ||
| 2. Use a new, purpose-built workflow (`crcr-l4-ci.yml`), gated by a PR **label** (`ciflow/crcr/crcr-test-L4`), to validate that at L4 a Check Run is created on the upstream PR and can block merge, with effectively zero blast radius on other people's PRs. |
Contributor
There was a problem hiding this comment.
I would be curious what are the next steps after that.
Author
There was a problem hiding this comment.
Hi @albanD, sorry for the late reply.
There are several steps after we have completed the test for L4:
- Start drafting the criteria for L4 (both promotion and demotion).
- Optimize the check-run behaviour and HUD from L1 to L4 as a whole.
- Since L4 could block the PR from merging, we need to consider a way to make it safer and more stable for unrelated failures (maybe with AI integration). But it is not a high-priority task for now since we won't have a real L4 repo within a short period of time.
L4 is attractive and could be an ultra-purpose for the downstream repos to engage with the CRCR system, so would be a lot of work to do :)
Contributor
There was a problem hiding this comment.
Let's add these details here! And Yes that sounds good.
Author
There was a problem hiding this comment.
Thanks for the review! Added below. Please take a look when you have time @albanD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.