Repository navigation
Cleanup - #884
Merged
Merged
Cleanup#884
Conversation
- Merge imports from same module into single import. - Expose some often used robot.utils via our utils.
1. Return value from `Register keyword to run on failure` can now always be used as an argument to the keyword. In practice the keyword nowadays returns `None` if the functionality was disabled and `None` (as well as `'NONE'`) can be used to disable the functionality. Fixes robotframework#176. 2. Moved the hook method to run when a keyword fails to the core. This simplifies implementation. The hook method was also renamed from `run_on_failure` to `failure_occurred`.
Renamed these: _run_on_failure_keyword _speed_in_secs _timeout_in_secs _implicit_wait_in_secs to these: run_on_failure_keyword speed timeout implicit_wait Original attributes still work but are deprecated. Deprecation isn't currently tested but unit tests could be added.
This was referenced Sep 2, 2017
Contributor
|
Looks good on mobile screen, need to take closer look from bigger screen. Spotted one thing though. |
The line 492 contained not needed q character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register keyword to run on failurecannot always be used to restore original state #176)This PR contains somewhat unrelated fixes, but commits ought to mainly contain only a single fix.