Repository navigation
Refactor GitHub Actions workflows - #764
Merged
Merged
Conversation
LeoColomb
marked this pull request as ready for review
June 16, 2023 23:05
LeoColomb
enabled auto-merge (squash)
June 17, 2023 01:48
Member
|
TIL about variables. Done 👍 |
swalkinshaw
approved these changes
Jun 17, 2023
swalkinshaw
left a comment
Member
There was a problem hiding this comment.
Are we expecting a test failure?
Collaborator
Author
|
@swalkinshaw Yes, the error was due to the vars. Now it runs 🎊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for this barely readable PR. 😬
The goal was to find a good compromise to make it run (the scripts folder is currently not available, workflow broken).
Steps to understand:
notesscript now creates the release itselfPACKAGE_PREFIX:wordpress-META_PACKAGE:roots/wordpress