Repository navigation
Conversation
The Bourne shell removes a backslash followed by a newline, both outside quotes and inside double quotes. shellsplit kept the backslash and the newline outside quotes, and kept the newline inside double quotes, so "foo\\<newline>bar" became "foo\\\nbar" instead of "foobar".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shellwords.splitis documented to split "in the same way the UNIX Bourne shell does", but it doesn't handle a backslash-newline line continuation. The shell removes\<newline>both outside quotes and inside double quotes:Before:
After:
A continuation on its own no longer produces a word, so
"foo \\\n"gives["foo"]and"\\\n"gives[]. Single-quoted text and the escaped-newline output ofshellescape('\n') are unchanged, and I added tests for these cases.