Skip to content

Tracking Issue for feature(string_drain_as_str) - string::Drain::as_str() #76905

New issue
New issue
Closed
#86858
Closed
Tracking Issue for feature(string_drain_as_str) - string::Drain::as_str()#76905
#86858
Labels
A-strArea: `str` and `String`C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

Description

@m-ou-se
m-ou-se
opened on Sep 19, 2020

Tracking Issue for string_drain_as_str as introduced by #76525.

Api:

  • Drain::as_str()
  • AsRef<str> for Drain
  • AsRef<[u8]> for Drain

The first one is now gated behind feature(string_drain_as_str). The other two are not available yet, as trait implementations cannot be unstable. These should be added (uncommented) when this feature is stabilized.

Activity

  1. m-ou-se
    added
    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFC
    on Sep 19, 2020
  2. rustbot
    added
    T-libs-api[DEPRECATED; DO NOT USE]
    A-strArea: `str` and `String`
    on Sep 19, 2020
  3. KodrAus
    added
    I-libs-radarLibs issues that are tracked on the team's radar.
    on Nov 6, 2020

  4. JohnTitor commented on Jun 17, 2021

    @JohnTitor
    JohnTitor
    on Jun 17, 2021
    Member

    Seems there's no blocker, could I ask you to kick off FCP to stabilize it?

  5. JohnTitor commented on Jun 21, 2021

    @JohnTitor
    JohnTitor
    on Jun 21, 2021
    Member

    cc @rust-lang/libs-api If it's reasonable, it'd be great if someone starts FCP :)

  6. yaahc
    added
    I-nominated
    on Jun 21, 2021

  7. joshtriplett commented on Jun 21, 2021

    @joshtriplett
    joshtriplett
    on Jun 21, 2021
    Member

    Do we have any confirmation of usage in the ecosystem? I don't see any problem with the method as designed, but can we confirm that it's being used?

  8. JohnTitor commented on Jun 21, 2021

    @JohnTitor
    JohnTitor
    on Jun 21, 2021
    Member

    Oh sorry, I don't have the real world use case, unfortunately. I just thought this is straightforward and makes the conversion around .drain(..) easier. And we cannot make any use that requires AsRef because it's hidden until we stabilize the feature.

  9. m-ou-se commented on Jun 23, 2021

    @m-ou-se
    m-ou-se
    on Jun 23, 2021
    MemberAuthor

    @rfcbot merge

  10. rfcbot commented on Jun 23, 2021

    @rfcbot
    rfcbot
    on Jun 23, 2021

    Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

    No concerns currently listed.

    Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

    See this document for info about what commands tagged team members can give me.

  11. rfcbot
    added
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    and removed
    proposed-final-comment-periodProposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off.
    on Jun 23, 2021

  12. rfcbot commented on Jun 23, 2021

    @rfcbot
    rfcbot
    on Jun 23, 2021

    🔔 This is now entering its final comment period, as per the review above. 🔔

  13. m-ou-se
    removed
    I-nominated
    on Jun 30, 2021
  14. rfcbot
    added
    finished-final-comment-periodThe final comment period is finished for this PR / Issue.
    and removed
    final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.
    on Jul 3, 2021

  15. rfcbot commented on Jul 3, 2021

    @rfcbot
    rfcbot
    on Jul 3, 2021

    The final comment period, with a disposition to merge, as per the review above, is now complete.

    As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

    The RFC will be merged soon.

  16. rfcbot
    added
    to-announceAnnounce this issue on triage meeting
    on Jul 3, 2021
  17. JohnTitor
    added a commit that references this issue on Jul 4, 2021

    Rollup merge of rust-lang#86858 - JohnTitor:stabilize-string-drain-as…

    28dba82
  18. bors
    closed this as completedin 28dba82on Jul 5, 2021
  19. apiraino
    removed
    to-announceAnnounce this issue on triage meeting
    on Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-strArea: `str` and `String`C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCI-libs-radarLibs issues that are tracked on the team's radar.T-libs-api[DEPRECATED; DO NOT USE]disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions