Repository navigation
Tracking Issue for asm_const #93332
Description
The feature gate for the issue is #![feature(asm_const)].
Summary
This feature adds a const <expr> operand type to asm! and global_asm!.
<expr>must be an integer constant expression.- The value of the expression is formatted as a string and substituted directly into the asm template string.
Status
Blocked on the stabilization of inline consts (#76001).
Reacted by ⭐️NINIKA⭐️, Gijs Burghoorn, Mateusz Jabłoński, José Luis Cruz and Raphaël Thériault
Activity
bstrie commentedon Jan 28, 2022
Is it possible that this may not actually be blocked on inline_const? AIUI, the concern was that stabilizing asm_const would expose the semantics of inline_const to stable, so any change to the semantics of the yet-unstable inline_const would potentially break stable users of asm_const. But AFAICT there are no more foreseen semantic changes coming to inline_const, and the only remaining question is a syntactic one, specifically with regard to how macros would consume
const {}blocks, which seems irrelevant toasm!which is providing its own syntax over inline_const anyway. Of course, it's worth asking to determine whether or not it's correct that the semantics of inline_const have truly solidified.Fix CI error about:
Fix CI error about:
arch/aarch64: Implement paging
arch/aarch64: Implement paging
arch/aarch64: Implement paging
arch/aarch64: Implement paging
aarch64: Implement paging
arch/aarch64: Implement paging
tiagomanczak commentedon May 10, 2023
Any progress on this issue? We are working in a project were it is necessary, and the stabilization is important for future use in productive code. Any forms we can contribute to the stabilization of asm_const?
nbdd0121 commentedon May 10, 2023
asm_constis blocked on stabilisation ofinline_constbecause it shares a lot of the same issue (e.g. post-mono errors)21 remaining items
rfcbot commentedon May 25, 2024
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
Lokathor commentedon May 25, 2024
@nbdd0121 is that a change that would need to happen now before stabilization, or would it be part of a later update allowing const str support?
Amanieu commentedon May 25, 2024
I have a draft PR up (#125558) but I'm hitting the same ICE as #96304 but with
constoperands.Rollup merge of rust-lang#128570 - folkertdev:stabilize-asm-const, r=…
Unrolled build for rust-lang#128570
ehuss commentedon Aug 14, 2024
@Amanieu Can this be closed now?
Rollup merge of #128570 - folkertdev:stabilize-asm-const, r=Amanieu
refactor(openvm): use asm_const for STACK_TOP in _start
refactor(openvm): use asm_const for STACK_TOP in _start
refactor(openvm): use asm_const for STACK_TOP in _start