Skip to content

Migrate run-make/duplicate-output-flavors to rmake.rs - #126542

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:migrate-run-make-duplicate-output-flavors
Jun 16, 2024
Merged

bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:migrate-run-make-duplicate-output-flavors

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

Part of #121876.

r? @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 16, 2024
@rustbot

rustbot commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@Kobzol

Kobzol commented Jun 16, 2024

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@bors

bors commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit ac751b3 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024
@bors

bors commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ac751b3 with merge f6236f6...

@bors

bors commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing f6236f6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2024
@bors
bors merged commit f6236f6 into rust-lang:master Jun 16, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 16, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f6236f6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -5.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-5.2% [-7.5%, -2.8%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -5.2% [-7.5%, -2.8%] 2

Cycles

Results (secondary 7.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
7.0% [7.0%, 7.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.776s -> 670.387s (-0.36%)
Artifact size: 319.83 MiB -> 320.49 MiB (0.20%)

@GuillaumeGomez
GuillaumeGomez deleted the migrate-run-make-duplicate-output-flavors branch June 16, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants