Skip to content

Correct documentation of what core::ops::Code is. - #163819

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kpreid:code
Oct 26, 2026
Merged

Correct documentation of what core::ops::Code is.#163819
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
kpreid:code

Conversation

@kpreid

@kpreid kpreid commented Oct 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

The documentation of core::ops::Code is currently incorrect; it describes its relationship to function pointers as if it was adding an indirection, not removing one.

Tracking issue for fn_static: #148768

@rustbot label +A-docs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2026
@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum, clarfonthey

@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Error: Unknown labels: F-fn_static

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rustbot rustbot added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Oct 5, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Oct 25, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c185038 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 25, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163819 - kpreid:code, r=Mark-Simulacrum
17c34aa 
Correct documentation of what `core::ops::Code` is.

The documentation of `core::ops::Code` is currently incorrect; it describes its relationship to function pointers as if it was adding an indirection, not removing one.

Tracking issue for `fn_static`: rust-lang#148768

@rustbot label +A-docs
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 25, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 25, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163819 - kpreid:code, r=Mark-Simulacrum
4a67984 
Correct documentation of what `core::ops::Code` is.

The documentation of `core::ops::Code` is currently incorrect; it describes its relationship to function pointers as if it was adding an indirection, not removing one.

Tracking issue for `fn_static`: rust-lang#148768

@rustbot label +A-docs
This was referenced Oct 25, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 25, 2026
@bors
Auto merge of #164928 - JonathanBrouwer:rollup-rc5pfiA, r=JonathanBro…
8592206 
…uwer

Rollup of 20 pull requests

Successful merges:

 - #163730 (add tests over re-entrancy guarantees for 160776)
 - #164834 (miri subtree update)
 - #164849 (Use the span of the doctest code block fence for figuring out the line number)
 - #164883 (rustdoc: don't panic on a nested use group with no path prefix)
 - #164890 (Store cold blocks in a bitset instead of a Vec of bools)
 - #163458 (stabilize {Rc, Arc}::is_unique)
 - #163499 (vec: stabilise allocators for into_iter)
 - #163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`)
 - #163816 (stabilize String::into_chars)
 - #163819 (Correct documentation of what `core::ops::Code` is.)
 - #163847 (add regression test for reborrow-invariant-type)
 - #164006 (Arduously fix typo)
 - #164009 (Update `Ready` future expect messages)
 - #164522 (Add IPv6 hop limit stubs to the motor OS net backend)
 - #164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact())
 - #164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs)
 - #164794 (Expose FloatErrorKind)
 - #164802 (Migrate stable-specific run-make tests to UI tests)
 - #164899 (Only recover if we may in `parse_expr_tuple_parens`)
 - #164903 (rustc-dev-guide subtree update)

Failed merges:

 - #164856 (Switch from `insta` to `expect-test` in bootstrap)
@rust-bors
rust-bors Bot merged commit e4a420c into rust-lang:main Oct 26, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
@bors
Unrolled build for #163819 in rollup 164928
096cc4d 
Rollup merge of #163819 - kpreid:code, r=Mark-Simulacrum

Correct documentation of what `core::ops::Code` is.

The documentation of `core::ops::Code` is currently incorrect; it describes its relationship to function pointers as if it was adding an indirection, not removing one.

Tracking issue for `fn_static`: #148768

@rustbot label +A-docs
moabo3li pushed a commit to moabo3li/miri that referenced this pull request Oct 26, 2026
@bors
Auto merge of #164928 - JonathanBrouwer:rollup-rc5pfiA, r=JonathanBro…
8849c7b 
…uwer

Rollup of 20 pull requests

Successful merges:

 - rust-lang/rust#163730 (add tests over re-entrancy guarantees for 160776)
 - rust-lang/rust#164834 (miri subtree update)
 - rust-lang/rust#164849 (Use the span of the doctest code block fence for figuring out the line number)
 - rust-lang/rust#164883 (rustdoc: don't panic on a nested use group with no path prefix)
 - rust-lang/rust#164890 (Store cold blocks in a bitset instead of a Vec of bools)
 - rust-lang/rust#163458 (stabilize {Rc, Arc}::is_unique)
 - rust-lang/rust#163499 (vec: stabilise allocators for into_iter)
 - rust-lang/rust#163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`)
 - rust-lang/rust#163816 (stabilize String::into_chars)
 - rust-lang/rust#163819 (Correct documentation of what `core::ops::Code` is.)
 - rust-lang/rust#163847 (add regression test for reborrow-invariant-type)
 - rust-lang/rust#164006 (Arduously fix typo)
 - rust-lang/rust#164009 (Update `Ready` future expect messages)
 - rust-lang/rust#164522 (Add IPv6 hop limit stubs to the motor OS net backend)
 - rust-lang/rust#164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact())
 - rust-lang/rust#164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs)
 - rust-lang/rust#164794 (Expose FloatErrorKind)
 - rust-lang/rust#164802 (Migrate stable-specific run-make tests to UI tests)
 - rust-lang/rust#164899 (Only recover if we may in `parse_expr_tuple_parens`)
 - rust-lang/rust#164903 (rustc-dev-guide subtree update)

Failed merges:

 - rust-lang/rust#164856 (Switch from `insta` to `expect-test` in bootstrap)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 30, 2026
@bors @flip1995
Auto merge of #164928 - JonathanBrouwer:rollup-rc5pfiA, r=JonathanBro…
ade8b27 
…uwer

Rollup of 20 pull requests

Successful merges:

 - rust-lang/rust#163730 (add tests over re-entrancy guarantees for 160776)
 - rust-lang/rust#164834 (miri subtree update)
 - rust-lang/rust#164849 (Use the span of the doctest code block fence for figuring out the line number)
 - rust-lang/rust#164883 (rustdoc: don't panic on a nested use group with no path prefix)
 - rust-lang/rust#164890 (Store cold blocks in a bitset instead of a Vec of bools)
 - rust-lang/rust#163458 (stabilize {Rc, Arc}::is_unique)
 - rust-lang/rust#163499 (vec: stabilise allocators for into_iter)
 - rust-lang/rust#163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`)
 - rust-lang/rust#163816 (stabilize String::into_chars)
 - rust-lang/rust#163819 (Correct documentation of what `core::ops::Code` is.)
 - rust-lang/rust#163847 (add regression test for reborrow-invariant-type)
 - rust-lang/rust#164006 (Arduously fix typo)
 - rust-lang/rust#164009 (Update `Ready` future expect messages)
 - rust-lang/rust#164522 (Add IPv6 hop limit stubs to the motor OS net backend)
 - rust-lang/rust#164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact())
 - rust-lang/rust#164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs)
 - rust-lang/rust#164794 (Expose FloatErrorKind)
 - rust-lang/rust#164802 (Migrate stable-specific run-make tests to UI tests)
 - rust-lang/rust#164899 (Only recover if we may in `parse_expr_tuple_parens`)
 - rust-lang/rust#164903 (rustc-dev-guide subtree update)

Failed merges:

 - rust-lang/rust#164856 (Switch from `insta` to `expect-test` in bootstrap)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 30, 2026
@bors
Auto merge of #164928 - JonathanBrouwer:rollup-rc5pfiA, r=JonathanBro…
764dc11 
…uwer

Rollup of 20 pull requests

Successful merges:

 - rust-lang/rust#163730 (add tests over re-entrancy guarantees for 160776)
 - rust-lang/rust#164834 (miri subtree update)
 - rust-lang/rust#164849 (Use the span of the doctest code block fence for figuring out the line number)
 - rust-lang/rust#164883 (rustdoc: don't panic on a nested use group with no path prefix)
 - rust-lang/rust#164890 (Store cold blocks in a bitset instead of a Vec of bools)
 - rust-lang/rust#163458 (stabilize {Rc, Arc}::is_unique)
 - rust-lang/rust#163499 (vec: stabilise allocators for into_iter)
 - rust-lang/rust#163805 (std: check `SO_ERROR` after poll in `TcpStream::connect_timeout`)
 - rust-lang/rust#163816 (stabilize String::into_chars)
 - rust-lang/rust#163819 (Correct documentation of what `core::ops::Code` is.)
 - rust-lang/rust#163847 (add regression test for reborrow-invariant-type)
 - rust-lang/rust#164006 (Arduously fix typo)
 - rust-lang/rust#164009 (Update `Ready` future expect messages)
 - rust-lang/rust#164522 (Add IPv6 hop limit stubs to the motor OS net backend)
 - rust-lang/rust#164602 (Improve seek_read_buf_exact() test coverage to match seek_read_exact())
 - rust-lang/rust#164772 (docs: Two nitpick changes to `HashMap`, `BTreeMap` Entry API docs)
 - rust-lang/rust#164794 (Expose FloatErrorKind)
 - rust-lang/rust#164802 (Migrate stable-specific run-make tests to UI tests)
 - rust-lang/rust#164899 (Only recover if we may in `parse_expr_tuple_parens`)
 - rust-lang/rust#164903 (rustc-dev-guide subtree update)

Failed merges:

 - rust-lang/rust#164856 (Switch from `insta` to `expect-test` in bootstrap)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kpreid @rustbot @Mark-Simulacrum