Repository navigation
Conversation
Collaborator
|
|
This comment was marked as resolved.
This comment was marked as resolved.
maxdexh
force-pushed
the
global-alloc-nounwind
branch
from
October 12, 2026 09:45
b7002f0 to
79b55c8
Compare
Member
|
...does this need FCP? prior docs already state that this is just a stand-in for |
Member
Author
|
It's a new guarantee. I think the decision to not go through an FCP would be reasonable though (I'm fine with either way) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With allocators about to be stabilized, we rely on this with
Globalalready, sinceAllocatorguarantees that there are no unwinds.Unless we want
Global.allocateandalloc::allocto behave differently wrt unwinds (and add a bunch of unwind guards to the implementation ofGlobal), I see no reason not to pass this guarantee down to users.r? nia-e