Repository navigation
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_target/src/spec/targets/amdgcn_amd_amdhsa.rs cc @Flakebi Target consistency checks are being changed cc @RalfJung These commits modify compiler targets. |
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
cc @adamgemmell |
Contributor
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of build-std: Standard library crate stability. More specifically:
standard_library_supportfield is added to the target spec, butmetadata.stdisn't removed yet.--print target-standard-library-supportis added to querystandard_library_support(output only in JSON, since Extend--printrequests with output format suffixes compiler-team#860 is apparently not implemented).How was
standard_library_supportset?metadata.std = Some(true)->standard_library_support.{supported,default} = "core, alloc, std"metadata.std = None->standard_library_support = Nonemetadata.std = Some(false)->standard_library_support.{supported,default} = "core, alloc"if the docs say that thealloccrate is supported.standard_library_support.{supported,default} = "core"if the docs explicitly say it's not supported or say nothing.aarch64_unknown_linux_pauthtestthe spec says full std is supported whilemetadata.stdwas false, so I changed it.Currently I set
defaultequal tosupported, as I think it's a reasonable start and target maintainers can change it in the future. Also, there might be other discrepancies with the spec (like foraarch64_unknown_linux_pauthtest), but I didn't check all the targets.Questions
supportedanddefault, but then in the examples it uses an array of crate names forsupportedand a single crate name fordefault. In the PR I used the first option.metadatafield?These are minor issues and I think they can be changed in the future anyway.
Future steps
--print target-standard-library-supportinstead ofmetadata.stdmetadata.stdLLM disclosure: no LLM was used.