Repository navigation
Add tests for -Zcrate-attr edition and position - #165429
Merged
Merged
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
wesleywiser
reviewed
Nov 3, 2026
Urgau
force-pushed
the
crate-attr-edition-position
branch
from
November 4, 2026 06:42
7b8d8aa to
138b927
Compare
wesleywiser
approved these changes
Nov 4, 2026
Member
|
@bors r+ rollup |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 5, 2026
… r=wesleywiser Add tests for `-Zcrate-attr` edition and position This PR adds new tests for `-Z crate-attr`: - first we check that the edition of the crate attributes is the same as `--edition` - second we add a test for `file!()`, `line!()` and `column!()` Note that [contrary to RFC](https://github.com/rust-lang/rfcs/blob/main/text/3791-crate-attr.md#spans-modules-and-editions) we currently consider `#![` and `]` relevant.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 5, 2026
… r=wesleywiser Add tests for `-Zcrate-attr` edition and position This PR adds new tests for `-Z crate-attr`: - first we check that the edition of the crate attributes is the same as `--edition` - second we add a test for `file!()`, `line!()` and `column!()` Note that [contrary to RFC](https://github.com/rust-lang/rfcs/blob/main/text/3791-crate-attr.md#spans-modules-and-editions) we currently consider `#![` and `]` relevant.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup of 13 pull requests Successful merges: - #163477 (Fancy paramenv accessors that communicate the access pattern better.) - #160593 (turn ABI-controlling target features into a target modifier) - #164896 (offload: pass the linked device image to the host pass) - #165468 (Remove return type from `BuilderMethods::store`) - #159374 (Lower #[no_mangle] to #[symbol_name]/#[link_name]) - #164564 (Re-enable outline-atomics by default on more AArch64 platforms) - #164623 (add next-solver regression tests for two fixed ices) - #164678 (add next-solver regression test for recursive opaque ICE under validate-mir) - #165429 (Add tests for `-Zcrate-attr` edition and position) - #165430 ([tiny] Show context for found assoc item in E0107) - #165456 (std: Fix build for the L4Re targets) - #165463 (Add BTreeMap::allocator and BTreeSet::allocator) - #165466 (Don't "exit" using `panic` on teeos)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup of 15 pull requests Successful merges: - #163477 (Fancy paramenv accessors that communicate the access pattern better.) - #160593 (turn ABI-controlling target features into a target modifier) - #164896 (offload: pass the linked device image to the host pass) - #165468 (Remove return type from `BuilderMethods::store`) - #164564 (Re-enable outline-atomics by default on more AArch64 platforms) - #164623 (add next-solver regression tests for two fixed ices) - #164653 (Deprecate internal function `vec::from_elem`) - #164678 (add next-solver regression test for recursive opaque ICE under validate-mir) - #165387 (windows OpenOptionsExt examples: replace winapi by windows crate) - #165429 (Add tests for `-Zcrate-attr` edition and position) - #165430 ([tiny] Show context for found assoc item in E0107) - #165456 (std: Fix build for the L4Re targets) - #165463 (Add BTreeMap::allocator and BTreeSet::allocator) - #165466 (Don't "exit" using `panic` on teeos) - #165491 (Remove unused compiler types and associated helpers)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup merge of #165429 - Urgau:crate-attr-edition-position, r=wesleywiser Add tests for `-Zcrate-attr` edition and position This PR adds new tests for `-Z crate-attr`: - first we check that the edition of the crate attributes is the same as `--edition` - second we add a test for `file!()`, `line!()` and `column!()` Note that [contrary to RFC](https://github.com/rust-lang/rfcs/blob/main/text/3791-crate-attr.md#spans-modules-and-editions) we currently consider `#![` and `]` relevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new tests for
-Z crate-attr:--editionfile!(),line!()andcolumn!()Note that contrary to RFC we currently consider
#![and]relevant.