Repository navigation
Make condasplit check-version required, flag condasplit Renovate updates and speed up its release [NOTASK] - #1219
Open
pditommaso wants to merge 3 commits into
Open
pditommaso wants to merge 3 commits into
pditommaso wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
APPROVE: a CI and Renovate config change with no correctness issue found.
What changed
build-condasplit.ymldrops itspathsfilter so it runs on every pull request. That is needed becausecheck-versionbecomes a required check: when a paths filter skips a required check, it stays pending and blocks the merge. On PRs that don't touch condasplit,make -C condasplit checkpasses in two cases: the tag is already published with the same source checksum, or the tag is "not published yet". So unrelated PRs aren't blocked. The default-image grep only reads files that are already in the repo, so it also passes when nothing changed.- In Renovate, the new
gomod+condasplit/**rule covers bothcondasplit/go.modandcondasplit/frontend/go.mod. It groups the updates, adds thecondasplit-bumplabel, and adds a body note about the requiredVERSIONand default-image bump. The rule comes after thegodirective rule and doesn't setenabled, so Go toolchain updates stay disabled.
Non-blocking notes
check-versionnow callsdocker buildx imagetools inspectagainstpublic.cr.seqera.ioon every PR. If the registry is down, the check fails and blocks every merge, not just condasplit changes. That's probably fine, but worth knowing.- The
testjob (Go vet and test in agolangcontainer) also runs on every PR now. It's cheap, but it could keep its own paths filter if you split it into a separate workflow, because onlycheck-versionneeds to run everywhere. - Renovate updates to the
golang:1.27base image incondasplit/Dockerfile(docker manager) also change the image sources, but the new rule doesn't label them. Consider addingdockerfiletomatchManagersso they get the same note. - Branch protection is configured outside the repo, so I couldn't verify that
check-versionis actually marked as required.
…t Renovate updates [NOTASK] Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
In CI the `imagetools inspect` of `make release` hangs ~17 minutes on a missing tag, the 1.42.2 release spent 20 of its 30 minutes in the condasplit step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pditommaso
force-pushed
the
condasplit-required-check
branch
from
October 28, 2026 11:03
ca60ebf to
edbe698
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The 1.42.2 release failed at
Publish condasplit image: the Renovate buildkit update (#1213) changed the condasplit sources without bumpingcondasplit/VERSION, so the release refused to publish the already existing immutablev2tag.check-versionfailed on #1213 but it is not a required check, so the PR was merged anyway (fixed on master by bumping tov3, 21fa507).Changes
build-condasplit.yml: drop thepathsfilter so the workflow runs on every pull request. A required check skipped by a paths filter stays pending and blocks unrelated PRs. Cost is small:check-version~8s,test~50s.build.yml: thePublish condasplit imagestep runsmake checkand thenmake buildonly when the tag is missing, instead ofmake release. In CI the secondimagetools inspectofmake releasehangs ~17 minutes on a missing tag: the 1.42.2 release spent 20 of its 30 minutes in that step, with a build of ~2.5 minutes. The Makefile is left untouched because it is part of the condasplit source checksum, changing it would need av4bump.renovate.json: group condasplit Go updates in their own PR, labelledcondasplit-bump, with a note to bumpcondasplit/VERSIONand thewave.build.condasplit-imagedefault.After merge
Add
check-versionto the required status checks of themasterbranch protection (repo admin setting, not part of this PR).🤖 Generated with Claude Code