Repository navigation
fix: improve freeze error messages when no custom build repository is set [NOTASK] - #1244
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the error messages returned when a container token request uses freeze mode without a custom build repository, replacing the cryptic
freeze mode [1]/[2]/[3]placeholders with messages that explain whybuildRepositoryis required.Root Cause & Problem
When a request enables freeze mode without specifying a
buildRepository,ContainerController.handleRequestrejects it with generic messages containing opaque numeric codes (... using freeze mode [1],[2],[3]). These give no indication of what the caller should change, which is especially confusing because freeze mode is allowed without an explicit repository in some cases (for example Conda or pip packages frozen to the default public Seqera Containers repository). See issue #723.Technical Solution
In
ContainerController, the three freeze-validation guards now throw descriptive messages:Test Plan
FreezeValidationTest, a lightweight Spock unit test that constructsContainerControllerdirectly with mocked collaborators (it does not boot the Micronaut application context), covering all three freeze-validation branches.gradle :test --tests io.seqera.wave.controller.FreezeValidationTest -x installTypeSpec -x generateOpenApi -x generateSwaggerUI→ BUILD SUCCESSFUL, 3 tests passed.ContainerControllerTestassertions to match the new messages so the full test suite stays green.Fixes #723