Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 32ca484 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Clicking the extension icon now opens the settings popup directly instead of requiring users to navigate to chrome://extensions.
There was a problem hiding this comment.
I would like to preserve the custom HTML element here (so page styles do not bleed inside it)
| Convert options page to extension popup | ||
|
|
||
| Clicking the extension icon now opens the settings popup directly instead of requiring users to navigate to chrome://extensions. |
There was a problem hiding this comment.
Keep it on one line (so changelog is readable)
|
@blakkd I like the idea Would it be possible to update the settings live ? When i change an option I need to refresh the page to take the new values into account (tested with "Scroll when clicking on a link or textarea" option) |
|
yep you are right, I'll try to not make a mess, first time I'll edit a PR! I hope it won't make you worry too much haha. Thanks for the review! |
|
I tried it on wikipedia.org homepage IIRC Options were working but not updating in real time (I needed to refresh the page after changing options) |
|
Oh no sorry I was meaning this
|
Ah no I didn't encounter any issue yet, but it might happen Having a custom element should not have any side effects anyway, apart having complète styles isolation |
|
Might make the update-on-change work |
Clicking the extension icon now opens the settings popup directly instead of requiring users to navigate to chrome://extensions.