Repository navigation
Forward PackageReference declaration locations to restore - #9905
Closed
AlesProkop wants to merge 1 commit into
Closed
AlesProkop wants to merge 1 commit into
AlesProkop wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
Closing in favour of https://dev.azure.com/devdiv/DevDiv/_git/dotnet-project-system/pullrequest/794612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by the internal dotnet-project-system draft PR 794612. The change has been ported to the active internal repository and validated against its current
main. This public draft is retained as a reference for the original prototype and its earlier validation; it is not the CPS PR to merge for the coordinated fix.Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2905535 (as part of the coordinated VS navigation fix, continued in the internal draft above).
Include
DefiningProjectFullPath,DefiningProjectLineNumber, andDefiningProjectColumnNumberin the collectedPackageReferencemetadata sent to NuGet. CPS only collects metadata listed in this rule, so MSBuild's source information currently never reaches restore. Existing change detection picks up these values, so moving a declaration refreshes nomination without changing package identity or forcing restore.The active CPS change is 3 of 4 in the recommended integration and rollout order. This is not a strict compile dependency chain; the full VS experience requires all four changes to ship.