Repository navigation
Preserve source locations when replaying restore diagnostics - #56655
Draft
AlesProkop wants to merge 1 commit into
Draft
AlesProkop wants to merge 1 commit into
AlesProkop wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 2 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2905535 as part of the coordinated Visual Studio navigation fix.
Preserve diagnostic files and coordinates through the SDK assets cache and MSBuild logging. Rebind supported diagnostics to current, uniquely identified PackageReference declarations so navigation remains correct when they move during a no-op restore. This is needed here because ResolvePackageAssets drops NuGet locations before Visual Studio displays the warning. Missing or ambiguous origins keep the project fallback; source-only moves do not rewrite restore files or invalidate the assets cache.
Merge 4 of 4. Recommended integration order is MSBuild → NuGet.Client → project-system → SDK, not a strict compile-dependency chain. The full Visual Studio fix needs all four changes to ship.
Companion PRs, in order: